Add framework for new tendency, revised PV diagnostics packages #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tendency and PV packages declarations to Registry.xml - Add Registry_tendencies.xml file with tendency package variables - Update Registry_diagnostics.xml with Registry_tendencies.xml and namelist config option declarations - Update Registry_pv.xml with all variables required to make modifications to PV diagnostics package
… variable packages - Added mpas_atm_diagnostics_packages.F in /src/core_atmosphere/diagnostics to setup the tendency and PV diagnostics packages based on config options and ensure comptability between the config options selected in the namelist - Modified Makefile in /src/core_atmosphere/diagnostics to reflect this new script - Modified mpas_atm_core_interface.F to call mpas_atm_diagnostics_packages.F to setup these packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes commits that provide the framework for a new tendencies diagnostics package and a significantly revised PV diagnostics package for MPAS-Atmosphere.
This framework includes a new
Registry_tendencies.xmlfile and the addition of a number of new variables inRegistry_pv.xml. These diagnostic variables are now connected to variable packages that are defined inRegistry.xmland tied to namelistconfig_*options (defined inRegistry_diagnostics.xml), enabling their activation at runtime. These new features and changes are described further in each commit.This PR corresponds to PR1 described in issue #1201.